Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/command/completion: add more unit-tests #5533

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

thaJeztah
Copy link
Member

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

Had some of these stashed while I was working on some earlier changes; looks like I never pushed them

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (21eea1e) to head (e1c472a).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5533      +/-   ##
==========================================
+ Coverage   60.67%   60.92%   +0.25%     
==========================================
  Files         345      345              
  Lines       23491    23491              
==========================================
+ Hits        14252    14313      +61     
+ Misses       8266     8205      -61     
  Partials      973      973              

@thaJeztah thaJeztah force-pushed the completions_coverage branch from 98b8ad6 to 2f04646 Compare October 13, 2024 16:57
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the completions_coverage branch from 2f04646 to e1c472a Compare October 13, 2024 17:09
@laurazard
Copy link
Member

laurazard commented Oct 14, 2024

Something else that this made me check/think about is that it'd be nice if the completion for commands that can take multiple arguments (such as docker rm [container] [container] didn't include arguments already added. I'll write a ticket

Thinking about this again, this is something that, if not handled by the shell, should be handled by the completions generated by cobra, not here.

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 31eeed7 into docker:master Oct 14, 2024
89 checks passed
@thaJeztah thaJeztah deleted the completions_coverage branch October 14, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants