-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/command/completion: add more unit-tests #5533
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Had some of these stashed while I was working on some earlier changes; looks like I never pushed them |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
+ Coverage 60.67% 60.92% +0.25%
==========================================
Files 345 345
Lines 23491 23491
==========================================
+ Hits 14252 14313 +61
+ Misses 8266 8205 -61
Partials 973 973 |
98b8ad6
to
2f04646
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
2f04646
to
e1c472a
Compare
Thinking about this again, this is something that, if not handled by the shell, should be handled by the completions generated by cobra, not here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- A picture of a cute animal (not mandatory but encouraged)