Switch from github.com/pkg/errors to %w-style wrap #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The github.com/pkg/errors is mostly obsoleted since Go 1.13 introduced
%w-style error wrapping. It is also not maintained and is now archived
by the owner. Let's switch to %s-style error wrapping.
Changes here are done by hand, touching code code which is not handled
correctly by the go-wrap-to-percent-w tool. The reason being,
errors.Wrap(err, "text") returns nil when err is nil, while
fmt.Errorf("text: %w", err) returns non-nil even if err is nil.
Signed-off-by: Kir Kolyshkin <[email protected]>
The github.com/pkg/errors is mostly obsoleted since Go 1.13 introduced %w-style error wrapping. It is also not maintained and is now archived by the owner. Let's switch to %s-style error wrapping. Generated by git ls-files *.go | grep -v '^vendor/' | xargs go-wrap-to-percent-w -w using https://github.com/AkihiroSuda/go-wrap-to-percent-w tool. Signed-off-by: Kir Kolyshkin <[email protected]>
1. Ditch wrapAsPluginError as we can simply use NewPluginError now. 2. Add a TODO to remove pluginError.Cause method. 3. Stop referring to pkg/errors method (except for 2 above). Signed-off-by: Kir Kolyshkin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
- Coverage 60.58% 60.54% -0.05%
==========================================
Files 345 345
Lines 23456 23465 +9
==========================================
- Hits 14211 14207 -4
- Misses 8273 8284 +11
- Partials 972 974 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github.com/pkg/errors is mostly obsoleted since Go 1.13 introduced %w-style error wrapping. It is also not maintained and is now archived by the owner.
Fixes: #3618
- What I did
- How I did it
Mostly by using https://github.com/AkihiroSuda/go-wrap-to-percent-w tool.
In some cases, by hand.
- How to verify it
I hope CI is adequate.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)