docs: Link supported Go duration strings #5507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Rogalski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5507 +/- ##
=======================================
Coverage 60.26% 60.26%
=======================================
Files 345 345
Lines 23448 23448
=======================================
Hits 14132 14132
Misses 8341 8341
Partials 975 975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation mentions "Go duration strings" several times. The first Google search result for "Go duration" gives https://pkg.go.dev/maze.io/x/duration#ParseDuration, which supports duration specifiers like
d,w,y. However, Go newbies (me) don't realize it's a third party package.This PR inserts links to the correct Go standard library package https://pkg.go.dev/time#ParseDuration, so people don't end up using unsupported duration specifiers.
Fixes #4390, relates to #2071
- Description for the changelog