Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rm.go #5501

Closed
wants to merge 1 commit into from
Closed

Update rm.go #5501

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 4, 2024

No description provided.

@laurazard
Copy link
Member

Hi @smith518, thanks for the contribution.

While I'd personally like to add some functionality like this to the CLI, I'm not sure we want to implement it at the CLI level (by having the CLI list all the containers, then make 1 call per container to the engine to remove them – I'd prefer we discussed making some changes to the daemon to allow to make a single call to remove multiple containers), but we haven't discussed that afaik.

Thoughts @thaJeztah?

@thaJeztah
Copy link
Member

Yeah, not sure about this; also because this overlaps with docker container prune (although that does, by design, not prune running containers).

I could see these kind of operations being useful for CI situations ("nuke" everything), but also a bit careful of making them too up-front as part of commands, as in non-CI situations, these are pretty destructive. For CI situations, most situations would already have a fair share of scripts and/or makefiles in place (which could provide this functionality without much effort).

@laurazard
Copy link
Member

Yeah, right. For the CI situation/anything scripted I think it's straightforward to write something like docker rm $(docker ps -aq) too, although it would be nice to have some better alternative to that.

@thaJeztah
Copy link
Member

Let me close this one for now, as this requires more discussion; there's an existing tracking ticket for this, which also links to other, related discussions;

@thaJeztah thaJeztah closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants