Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images Tree: Change 'Used' to 'In Use' #5474

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Images Tree: Change 'Used' to 'In Use' #5474

merged 1 commit into from
Sep 24, 2024

Conversation

cpuguy83
Copy link
Collaborator

@cpuguy83 cpuguy83 commented Sep 23, 2024 •
edited by thaJeztah
Loading

I was showing off docker images --tree and it came up (@tianon) that Used is not quite the right term here.

- Description for the changelog

- containerd image store:  change name of `USED` column in `docker image ls --tree` to `IN USE`.

@cpuguy83 cpuguy83 requested a review from vvoland September 23, 2024 18:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (9d478be) to head (df52ddc).
Report is 45 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5474   +/-   ##
=======================================
  Coverage   59.74%   59.74%           
=======================================
  Files         345      345           
  Lines       23431    23431           
=======================================
  Hits        13999    13999           
  Misses       8458     8458           
  Partials      974      974

@tianon
Copy link
Contributor

tianon commented Sep 23, 2024

picture of the "Welcome to Fabulous Goodwill Las Vegas" sign

😇

laurazard
laurazard approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this does sound better 😅 LGTM

@thaJeztah thaJeztah added status/2-code-review area/ux containerd-integration Issues and PRs related to containerd integration labels Sep 24, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Sep 24, 2024
thaJeztah
thaJeztah approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 56d0af7 into master Sep 24, 2024
110 of 113 checks passed
@thaJeztah thaJeztah deleted the change_to_inuse branch September 24, 2024 08:40
@thaJeztah
Copy link
Member

OH, lol; looks like you opened this PR from a branch on this repository, not your fork

@cpuguy83
Copy link
Collaborator Author

Oops , fresh checkout on a new machine. Didn't think to fix it. 🙀

@thaJeztah
Copy link
Member

No worries; no harm done ❤️

@thaJeztah thaJeztah mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurazard laurazard laurazard approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@vvoland vvoland Awaiting requested review from vvoland

Assignees
No one assigned
Labels
area/ux containerd-integration Issues and PRs related to containerd integration impact/changelog kind/enhancement process/cherry-picked status/2-code-review
Projects
None yet
Milestone
28.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cpuguy83 @codecov-commenter @tianon @thaJeztah @laurazard