volume/update: require 1 argument/fix panic #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command was declaring that it requires at least 1 argument, when it needs exactly 1 argument. This was causing the CLI to panic when the command was invoked with no argument: `docker volume update` Signed-off-by: Laura Brehm <[email protected]>
laurazard
force-pushed
the
fix-panic-volume-update
branch
from
a07fd44 to
daea277
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5420 +/- ##
==========================================
+ Coverage 59.73% 59.78% +0.04%
==========================================
Files 345 345
Lines 23394 23394
==========================================
+ Hits 13974 13985 +11
+ Misses 8450 8438 -12
- Partials 970 971 +1 |
|
Oof a test as well! That's thorough |
vvoland
approved these changes
Sep 9, 2024
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5418
- What I did
This command was declaring that it requires at least 1 argument, when it needs exactly 1 argument. This was causing the CLI to panic when the command was invoked with no argument.
- How I did it
Require exactly 1 argument.
- How to verify it
docker volume update- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)