[25.0 backport] fix flaky connhelper tests
#5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this test was failing due to bad syntax on the `while` loop, which caused it to die after 1 second. If the test took a bit longer, the process would be dead before the following assertions run, causing the test to fail/be flaky. Signed-off-by: Laura Brehm <[email protected]> (cherry picked from commit cc68c66) Signed-off-by: Laura Brehm <[email protected]>
Follow up to cc68c66 (there were more tests with incorrect syntax). Signed-off-by: Laura Brehm <[email protected]> (cherry picked from commit 4a7388f) Signed-off-by: Laura Brehm <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 25.0 #5292 +/- ##
=======================================
Coverage 61.35% 61.36%
=======================================
Files 290 290
Lines 20098 20098
=======================================
+ Hits 12332 12334 +2
+ Misses 6872 6871 -1
+ Partials 894 893 -1 |
Benehiko
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #5290 and #5291