cli/config/credentials: move warning to fileStore #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5259 +/- ##
==========================================
- Coverage 61.49% 61.46% -0.03%
==========================================
Files 299 299
Lines 20822 20820 -2
==========================================
- Hits 12804 12797 -7
- Misses 7109 7112 +3
- Partials 909 911 +2 |
The fileStore itself is aware that it's insecure, so we can make it responsible for printing the warning. It's not "perfect", as we use `os.Stderr` unconditionally (not `dockerCli.Err()`), but probably won't make a difference in _most_ cases. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_file_warning
branch
from
6adc409 to
ab80ea3
Compare
|
@laurazard good to merge this one? (it will require a rebase and changes in your PR) |
|
Oh, yup! No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/config/credentials: move warning to fileStore
The fileStore itself is aware that it's insecure, so we can make it
responsible for printing the warning. It's not "perfect", as we use
os.Stderrunconditionally (notdockerCli.Err()), but probably won'tmake a difference in most cases.
- A picture of a cute animal (not mandatory but encouraged)