vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev) #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/runtime
area/dependencies
area/go-sdk
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5170 +/- ##
=======================================
Coverage 61.76% 61.76%
=======================================
Files 297 297
Lines 20768 20768
=======================================
Hits 12828 12828
Misses 7024 7024
Partials 916 916 |
|
@laurazard @vvoland PTAL 🤗 |
thaJeztah
changed the title
thaJeztah
changed the title
thaJeztah
changed the title
thaJeztah
changed the title
thaJeztah
changed the title
thaJeztah
changed the title
thaJeztah
changed the title
thaJeztah
commented
Jun 20, 2024
| @@ -50,7 +50,7 @@ func (s *stats) isKnownContainer(cid string) (int, bool) { | |||
| return -1, false | |||
| } | |||
|
|
|||
| func collect(ctx context.Context, s *Stats, cli client.APIClient, streamStats bool, waitFirst *sync.WaitGroup) { | |||
| func collect(ctx context.Context, s *Stats, cli client.ContainerAPIClient, streamStats bool, waitFirst *sync.WaitGroup) { | |||
There was a problem hiding this comment.
Changed this to a narrower interface, as it doesn't need all of api-client
thaJeztah
commented
Jun 20, 2024
| "github.com/docker/docker/api/types" | ||
| ) | ||
|
|
||
| func TestCalculateBlockIO(t *testing.T) { |
There was a problem hiding this comment.
Merged this test into the other test-file (stats_helpers_test.go)
sam-thibault
approved these changes
Jun 20, 2024
|
May be doing one more update to include moby/moby#48011 |
Rewrite local code to use the new container.Ulimit alias to start transitioning away from direct uses of go-units.Ulimit. full diff: moby/moby@v27.0.0-rc.2...1a1f3cf Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
|
Updated, with moby/moby#48011 included |
vvoland
approved these changes
Jun 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev)
Rewrite local code to use the new container.Ulimit alias to start
transitioning away from direct uses of go-units.Ulimit.
full diff: moby/moby@v27.0.0-rc.2...1a1f3cf
- A picture of a cute animal (not mandatory but encouraged)