Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] docs: update host-gateway-ip to use daemon.json instead of cli flag #4819

Merged

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jan 23, 2024

Signed-off-by: David Karlsson [email protected]

- What I did

Changes the host-gateway-ip example to use daemon.json config instead of cli flag.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: David Karlsson <[email protected]>
(cherry picked from commit ec0a624)
@dvdksn dvdksn requested a review from thaJeztah as a code owner January 23, 2024 15:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Merging #4819 (4caf4de) into 25.0 (950ecd4) will increase coverage by 0.41%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             25.0    #4819      +/-   ##
==========================================
+ Coverage   59.22%   59.63%   +0.41%     
==========================================
  Files         285      287       +2     
  Lines       24770    24777       +7     
==========================================
+ Hits        14669    14775     +106     
+ Misses       9213     9114      -99     
  Partials      888      888              

@thaJeztah thaJeztah added this to the 25.0.1 milestone Jan 23, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 29cf629 into docker:25.0 Jan 23, 2024
75 checks passed
@dvdksn dvdksn deleted the 25.0_backport_docs_host-gateway-ip_daemonjson branch January 23, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants