-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in dockerd reference documentation #4687
Conversation
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a
There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle, and let me know if you need help or more detailed instructions! |
Signed-off-by: Graeme Wiebe <[email protected]>
My apologies, the sign-off you linked said:
So I thought just adding it to the commit message was fine. Everything should be good to go now. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4687 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 287 287
Lines 24821 24821
=======================================
Hits 14832 14832
Misses 9103 9103
Partials 886 886 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
- What I did
- Fixed a typo in the docker daemon reference docs
- How I did it
- How to verify it
- Description for the changelog
Fixed a typo in the docker daemon reference documentation
- A picture of a cute animal (not mandatory but encouraged)