vendor: github.com/docker/docker cfdca8dc1d4c (v25.0.0-dev)

[thaJeztah]

• relates to api/t/swarm: Fix deprecation for ServiceSpec.Networks moby/moby#46481

full diff: moby/moby@v25.0.0-beta.1...cfdca8d

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

No significant changes, so I'll keep this in draft for now.

[codecov-commenter]

Codecov Report

Merging #4673 (72a0f94) into master (6d820e8) will not change coverage.
The diff coverage is 33.33%.

❗ Current head 72a0f94 differs from pull request most recent head 539537d. Consider uploading reports for the commit 539537d to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4673   +/-   ##
=======================================
  Coverage   59.75%   59.75%           
=======================================
  Files         287      287           
  Lines       24821    24821           
=======================================
  Hits        14832    14832           
  Misses       9103     9103           
  Partials      886      886           

[thaJeztah]

• Oh! Actually relevant changes. I actually wanted to update the vendor because of those, but then thought they were not part of vendor, but they are; api/t/swarm: Fix deprecation for ServiceSpec.Networks moby/moby#46481 (comment)

60.33 cli/command/service/update.go:1298:18: SA1019: spec.Networks is deprecated: This field is deprecated since v1.44. The Networks field in TaskSpec should be used instead. (staticcheck)
60.33 		specNetworks = spec.Networks
60.33 		               ^
60.33 cli/command/service/update.go:1300:2: SA1019: spec.Networks is deprecated: This field is deprecated since v1.44. The Networks field in TaskSpec should be used instead. (staticcheck)
60.33 	spec.Networks = nil
60.33 	^
60.33 cli/compose/convert/service.go:177:3: SA1019: serviceSpec.Networks is deprecated: This field is deprecated since v1.44. The Networks field in TaskSpec should be used instead. (staticcheck)
60.33 		serviceSpec.Networks = networks
60.33 		^

⚠️ if we update, we probably may have to do so based on API version, or otherwise make sure that the apiClient itself takes care of that.

[thaJeztah]

⚠️ if we update, we probably may have to do so based on API version, or otherwise make sure that the apiClient itself takes care of that.

Chatted with @akerouanton and conversion is already there, so we only needed nolint comments 👍

[akerouanton]

LGTM!