mount: bind-recursive: remove boolean convenience values #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updates fc6976d - updates 74bace1 Commit fc6976d introduced support for the `bind-recursive` option on `--mount`, and deprecated the `bind-nonrecursive` option. Unlike `bind-nonrecursive` boolean, the `bind-recursive` option accepts a string value with multiple options. For convenience, the `bind-recursive` option also was made to accept boolean values (true/false, 1/0). However, as the option works as the _reverse_ of `bind-nonrecursive` (`bind-nonrecursive=true` === `bind-recursive=false`), the new option won't be a "drop-in" replacement, and having more options to choose from may only be adding more complexity / cognitive overload. This patch removes support for boolean values; if we see a need to add support for boolean values in future, it would be trivial to add back this functionality. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was referenced Nov 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4671 +/- ##
==========================================
+ Coverage 59.72% 59.73% +0.01%
==========================================
Files 287 287
Lines 24832 24824 -8
==========================================
- Hits 14831 14829 -2
+ Misses 9115 9110 -5
+ Partials 886 885 -1 |
dvdksn
approved these changes
Nov 22, 2023
AkihiroSuda
approved these changes
Nov 22, 2023
vvoland
approved these changes
Nov 22, 2023
|
Thanks for review! Let me bring this one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind-recursive=<bool|string>and deprecatebind-nonrecursive=<bool>#4316bind-recursivemount option #4606bind-recursive=<bool|string>and deprecatebind-nonrecursive=<bool>#4316bind-recursivemount option #4606Commit fc6976d (#4316) introduced support for the
bind-recursiveoption on--mount, and deprecated thebind-nonrecursiveoption. Unlikebind-nonrecursiveboolean, thebind-recursiveoption accepts a string value with multiple options.For convenience, the
bind-recursiveoption also was made to accept boolean values (true/false, 1/0). However, as the option works as the reverse ofbind-nonrecursive(bind-nonrecursive=true===bind-recursive=false), the new option won't be a "drop-in" replacement, and having more options to choose from may only be adding more complexity / cognitive overload.This patch removes support for boolean values; if we see a need to add support for boolean values in future, it would be trivial to add back this functionality.
- A picture of a cute animal (not mandatory but encouraged)