opts: remove unused IPOpt option #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was created Moby [6d59a56], and used for the daemon config [353b7c8]. It was migrated from the Moby repository in f34ca0a, but was never used by the CLI, and there are no external consumers. If we would need an IP-address option, spf13/pflags now provides those, so there's no need to implement this ourselves. [6d59a56]: moby/moby@6d59a56 [353b7c8]: moby/moby@353b7c8 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4658 +/- ##
==========================================
- Coverage 59.74% 59.72% -0.03%
==========================================
Files 288 287 -1
Lines 24849 24829 -20
==========================================
- Hits 14846 14828 -18
+ Misses 9117 9115 -2
Partials 886 886 |
sam-thibault
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was created Moby 6d59a566759da5729d7eb89a8e1888fc612f03cf, and used for the daemon config 353b7c8ec77b30fa83dac5ec0778193f6de8b437. It was migrated from the Moby repository in f34ca0a, but was never used by the CLI, and there are no external consumers.
If we would need an IP-address option, spf13/pflags now provides those, so there's no need to implement this ourselves.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)