cli/command/container: ForwardAllSignals: rewrite to use ContainerAPIClient #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4638 +/- ##
=======================================
Coverage 59.74% 59.74%
=======================================
Files 288 288
Lines 24849 24849
=======================================
Hits 14846 14846
Misses 9117 9117
Partials 886 886 |
thaJeztah
force-pushed
the
ForwardAllSignals_no_cli
branch
2 times, most recently
from
ce59280 to
7497075
Compare
…Client This function only needed the ContainerAPIClient, and not the whole CLI. This patch refactors it to use the shallower interface. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
ForwardAllSignals_no_cli
branch
from
7497075 to
3cd77c9
Compare
|
@laurazard @rumpl ptal |
neersighted
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function only needed the ContainerAPIClient, and not the whole CLI. This patch refactors it to use the shallower interface.
- A picture of a cute animal (not mandatory but encouraged)