Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/docker/docker fc4d035e7a4e (v25.0.0-dev) #4625

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 25, 2023

vendor: github.com/go-logr/logr v1.2.4

full diff: go-logr/logr@v1.2.3...v1.2.4

vendor: github.com/klauspost/compress v1.17.2

fixes data corruption with zstd output in "best"

vendor: github.com/moby/swarmkit/v2 v2.0.0-20230911190601-f082dd7a0cee

no changes in vendored files

full diff: moby/swarmkit@12f0c24...f082dd7

vendor: github.com/opencontainers/image-spec v1.1.0-rc5

full diff: opencontainers/image-spec@v1.1.0-rc4...v1.1.0-rc5

vendor: github.com/docker/docker fc4d035e7a4e (v25.0.0-dev)

full diff: moby/moby@cdb3f9f...fc4d035

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

github.com/opencontainers/runc v1.1.7 // indirect
github.com/moby/sys/user v0.1.0 // indirect
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes runc as dependency from the CLI 🎉

@thaJeztah thaJeztah changed the title vendor: github.com/docker/docker e36260f39abd (v25.0.0-dev) vendor: github.com/docker/docker 4776a9e6fb3c (v25.0.0-dev) Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #4625 (663a89b) into master (dd11de7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4625   +/-   ##
=======================================
  Coverage   59.74%   59.74%           
=======================================
  Files         288      288           
  Lines       24849    24849           
=======================================
  Hits        14846    14846           
  Misses       9117     9117           
  Partials      886      886           

@thaJeztah thaJeztah marked this pull request as draft October 25, 2023 21:13
@thaJeztah thaJeztah changed the title vendor: github.com/docker/docker 4776a9e6fb3c (v25.0.0-dev) vendor: github.com/docker/docker fc4d035e7a4e (v25.0.0-dev) Oct 25, 2023
Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I trust that docker/docker repo 😉

Note, this PR is still in draft.

@thaJeztah thaJeztah marked this pull request as ready for review October 26, 2023 07:31
@thaJeztah
Copy link
Member Author

Note, this PR is still in draft.

Yes, I decided to move #4626 and #4627 to separate PRs for visibility as they were candidates for back-porting, but the commits were still in this branch.

I just rebased this branch to get rid of those commits, and will bring this in once CI finished.

@thaJeztah thaJeztah merged commit 5fc42fc into docker:master Oct 26, 2023
74 checks passed
@thaJeztah thaJeztah deleted the bump_engine branch October 26, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants