cli/command: merge DockerCliOption and InitializeOpt types #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4387 +/- ##
=======================================
Coverage 59.77% 59.77%
=======================================
Files 287 287
Lines 24830 24830
=======================================
Hits 14841 14841
Misses 9103 9103
Partials 886 886 |
thaJeztah
force-pushed
the
single_cli_option
branch
from
23b0a38 to
f71363e
Compare
thaJeztah
force-pushed
the
single_cli_option
branch
from
f71363e to
ef7e677
Compare
thaJeztah
force-pushed
the
single_cli_option
branch
from
ef7e677 to
0883e84
Compare
The cli/command package defined two option-types with the same signature. This patch creates a new type instead (CLIOption), and makes the existing types an alias for this (deprecating their old names). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
single_cli_option
branch
from
0883e84 to
7af509c
Compare
vvoland
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli/command package defined two option-types with the same signature.
This patch creates a new type instead (CLIOption), and makes the existing types an alias for this (deprecating their old names).
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)