Skip to content

Commit

Permalink
Merge pull request #5426 from thaJeztah/27.x_backport_fix-panic-volum…
Browse files Browse the repository at this point in the history
…e-update

[27.x backport] volume/update: require 1 argument/fix panic
  • Loading branch information
laurazard authored Sep 11, 2024
2 parents 05fb576 + 965699b commit fba240c
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
2 changes: 1 addition & 1 deletion cli/command/volume/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func newUpdateCommand(dockerCli command.Cli) *cobra.Command {
cmd := &cobra.Command{
Use: "update [OPTIONS] [VOLUME]",
Short: "Update a volume (cluster volumes only)",
Args: cli.RequiresMaxArgs(1),
Args: cli.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
return runUpdate(cmd.Context(), dockerCli, args[0], availability, cmd.Flags())
},
Expand Down
22 changes: 22 additions & 0 deletions cli/command/volume/update_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package volume

import (
"io"
"testing"

"github.com/docker/cli/internal/test"
"gotest.tools/v3/assert"
)

func TestUpdateCmd(t *testing.T) {
cmd := newUpdateCommand(
test.NewFakeCli(&fakeClient{}),
)
cmd.SetArgs([]string{})
cmd.SetOut(io.Discard)
cmd.SetErr(io.Discard)

err := cmd.Execute()

assert.ErrorContains(t, err, "requires exactly 1 argument")
}

0 comments on commit fba240c

Please sign in to comment.