-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: opt to set progress warnings in response #2551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/build
area/cli
area/ci
area/controller
area/hack
area/docs
area/tests
labels
Jun 24, 2024
crazy-max
force-pushed
the
metadata-warnings-2
branch
13 times, most recently
from
June 25, 2024 09:27
7216374
to
b4173f0
Compare
tonistiigi
reviewed
Jun 25, 2024
crazy-max
force-pushed
the
metadata-warnings-2
branch
from
June 25, 2024 19:41
b4173f0
to
777ac2f
Compare
crazy-max
force-pushed
the
metadata-warnings-2
branch
2 times, most recently
from
June 26, 2024 04:39
5568fde
to
d263b7c
Compare
tonistiigi
reviewed
Jun 26, 2024
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
metadata-warnings-2
branch
from
June 26, 2024 04:53
d263b7c
to
01a50aa
Compare
tonistiigi
approved these changes
Jun 26, 2024
5 tasks
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #2511 and similar to #2280, we can set build checks warnings in the metadata file. Does not set them by default but can be enabled by using the
BUILDX_METADATA_WARNINGS=1
environment variable.This will be useful with our GitHub Actions so we can generate GitHub Annotations without having to do a subrequest build like in https://github.com/crazy-max/docker-build-push-action/pull/39/files#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR132
@tonistiigi Also added extra commit to dedup warnings for bake related to #2534 (comment)
# syntax=docker/dockerfile-upstream:master frOM busybox as base cOpy Dockerfile . from scratch COPy --from=base \ /Dockerfile \ /
md.json