Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update to Docker Engine v25.0.1 #2204

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 24, 2024

@thaJeztah thaJeztah self-assigned this Jan 24, 2024
@thaJeztah
Copy link
Member Author

Nice! It's failing with v25.0.0, that's what I was hoping to see;

=== FAIL: tests TestIntegration/TestDockerHostGateway/worker=docker (2.54s)
    build.go:432: 
        	Error Trace:	/src/tests/build.go:432
        	            				/src/vendor/github.com/moby/buildkit/util/testutil/integration/run.go:91
        	            				/src/vendor/github.com/moby/buildkit/util/testutil/integration/run.go:205
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	TestIntegration/TestDockerHostGateway/worker=docker
        	Messages:   	ERROR: unable to derive the IP value for host-gateway: failed to parse host-gateway IP: <nil>
    sandbox.go:128: stdout: /usr/bin/dockerd
    sandbox.go:128: stderr: /usr/bin/dockerd
=== FAIL: tests TestIntegration/TestDockerHostGateway/worker=docker+containerd (2.48s)
    build.go:432: 
        	Error Trace:	/src/tests/build.go:432
        	            				/src/vendor/github.com/moby/buildkit/util/testutil/integration/run.go:91
        	            				/src/vendor/github.com/moby/buildkit/util/testutil/integration/run.go:205
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	TestIntegration/TestDockerHostGateway/worker=docker+containerd
        	Messages:   	ERROR: unable to derive the IP value for host-gateway: failed to parse host-gateway IP: <nil>
    sandbox.go:128: stdout: /usr/bin/dockerd
    sandbox.go:128: stderr: /usr/bin/dockerd

I'll update it to use v25.0.1 now, which should have the fix; moby/moby#47187

Update DOCKER_VERSION to the current release, so that tests run
against that version.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the ci_update_docker_version branch from afc1f0a to 2478f30 Compare January 24, 2024 10:01
@thaJeztah thaJeztah changed the title Dockerfile: update to Docker Engine v25.0.0 Dockerfile: update to Docker Engine v25.0.1 Jan 24, 2024
@thaJeztah thaJeztah marked this pull request as ready for review January 24, 2024 10:57
@thaJeztah thaJeztah requested a review from crazy-max January 24, 2024 10:58
@thaJeztah
Copy link
Member Author

Whoop, and green with v25.0.1 👍

@crazy-max crazy-max merged commit 7e4021a into docker:master Jan 24, 2024
61 checks passed
@thaJeztah thaJeztah deleted the ci_update_docker_version branch January 24, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants