update to go 1.21.3 #2084
Merged
update to go 1.21.3 #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
ktock
reviewed
Oct 18, 2023
bake/bake.go
Outdated
| func ReadTargets(ctx context.Context, files []File, targets, overrides []string, defaults map[string]string) (map[string]*Target, map[string]*Group, error) { | ||
| func ReadTargets(_ context.Context, files []File, targets, overrides []string, defaults map[string]string) (map[string]*Target, map[string]*Group, error) { |
There was a problem hiding this comment.
Looks like revive linter error? Recent revive seems too strict so maybe we can have some exclude-rules like this: https://github.com/moby/buildkit/blob/3dedf3c5e72c55e2a61cd98e67e0f461d545b195/.golangci.yml#L61
There was a problem hiding this comment.
Ah gotcha thanks. I was wondering why we had so many issues. Let me check.
There was a problem hiding this comment.
I have aligned the rules with buildkit ones.
tonistiigi
approved these changes
Oct 19, 2023
also update config to show all issues at once and set same exlucde rules as buildkit ones. Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
ktock
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tip.golang.org/doc/go1.21
Updates golangci-lint to 1.54.2 and its configuration to show all lint issues and align exclude rules with buildkit ones as well: https://github.com/golangci/golangci-lint/releases/tag/v1.54.2