Skip to content

Commit

Permalink
test: docker host-gateway
Browse files Browse the repository at this point in the history
Signed-off-by: CrazyMax <[email protected]>
  • Loading branch information
crazy-max committed Oct 17, 2023
1 parent 05af608 commit 9c01ba0
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ARG GO_VERSION=1.20.8
ARG XX_VERSION=1.2.1

ARG DOCKER_VERSION=24.0.2
ARG DOCKER_VERSION=24.0.6
ARG GOTESTSUM_VERSION=v1.9.0
ARG REGISTRY_VERSION=2.8.0
ARG BUILDKIT_VERSION=v0.11.6
Expand Down
24 changes: 24 additions & 0 deletions tests/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ var buildTests = []func(t *testing.T, sb integration.Sandbox){
testBuildCacheExportNotSupported,
testBuildOCIExportNotSupported,
testBuildMultiPlatformNotSupported,
testDockerHostGateway,
}

func testBuild(t *testing.T, sb integration.Sandbox) {
Expand Down Expand Up @@ -415,3 +416,26 @@ func testBuildMultiPlatformNotSupported(t *testing.T, sb integration.Sandbox) {
require.Error(t, err, string(out))
require.Contains(t, string(out), "Multi-platform build is not supported")
}

func testDockerHostGateway(t *testing.T, sb integration.Sandbox) {
dockerfile := []byte(`
FROM alpine
RUN apk add syslinux
RUN gethostip host.docker.internal | tee /hostip.txt
FROM scratch
COPY --from=0 /hostip.txt /hostip.txt
`)
dir := tmpdir(t, fstest.CreateFile("Dockerfile", dockerfile, 0600))
cmd := buildxCmd(sb, withArgs("build", "--add-host=host.docker.internal:host-gateway", fmt.Sprintf("--output=type=local,dest=%s/result", dir), dir))
out, err := cmd.CombinedOutput()
if !isDockerWorker(sb) {
require.Error(t, err, string(out))
require.Contains(t, string(out), "host-gateway is not supported")
} else {
require.NoError(t, err, string(out))
dt, err := os.ReadFile(dir + "/result/hostip.txt")
require.NoError(t, err)
require.Contains(t, string(dt), "host.docker.internal")
}
}
9 changes: 9 additions & 0 deletions tests/inspect.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,25 @@ func testInspect(t *testing.T, sb integration.Sandbox) {

var name string
var driver string
var hostGatewayIP string
for _, line := range strings.Split(out, "\n") {
if v, ok := strings.CutPrefix(line, "Name:"); ok && name == "" {
name = strings.TrimSpace(v)
}
if v, ok := strings.CutPrefix(line, "Driver:"); ok && driver == "" {
driver = strings.TrimSpace(v)
}
if v, ok := strings.CutPrefix(line, " org.mobyproject.buildkit.worker.moby.host-gateway-ip:"); ok {
hostGatewayIP = strings.TrimSpace(v)
}
}

require.Equal(t, sb.Address(), name)
sbDriver, _, _ := strings.Cut(sb.Name(), "+")
require.Equal(t, sbDriver, driver)
if isDockerWorker(sb) {
require.NotEmpty(t, hostGatewayIP, "host-gateway-ip worker label should be set with docker driver")
} else {
require.Empty(t, hostGatewayIP, "host-gateway-ip worker label should not be set with non-docker driver")
}
}

0 comments on commit 9c01ba0

Please sign in to comment.