Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test supported node versions #488

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Nov 10, 2024

GitHub runners support both node 18 and 20.

@crazy-max crazy-max force-pushed the test-node-multi branch 2 times, most recently from 502315a to 56aea2b Compare November 10, 2024 21:38
@trim21
Copy link
Contributor

trim21 commented Nov 10, 2024

it's actually 16 and 20

@crazy-max
Copy link
Member Author

it's actually 16 and 20

Node 18 is the default node version running on hosted runners atm (except ubuntu-2404 with Node 20). Node 16 is EOL since 11 Sep 2023 so don't care much about it. I guess you meant the node16 runtime which uses node20: https://github.com/actions/runner/blob/6ef5803f24724b77a8d3599a478d06018da5d7c6/src/Runner.Worker/Handlers/HandlerFactory.cs#L60-L65

@trim21
Copy link
Contributor

trim21 commented Nov 10, 2024

thanks, didn't know there is a node18 runner.

@crazy-max crazy-max merged commit d99f9fd into docker:main Nov 22, 2024
41 checks passed
@crazy-max crazy-max deleted the test-node-multi branch November 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants