docker/install: Fix lima failing to download latest Docker archive #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the actual version number resolved from the Github releases instead of the `latest` string. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
docker-install-archive-version
branch
from
6a5851c to
e2acba1
Compare
crazy-max
reviewed
Oct 29, 2024
| @@ -230,7 +230,7 @@ export class Install { | |||
| daemonConfig: limaDaemonConfig, | |||
| dockerSock: `${limaDir}/docker.sock`, | |||
| srcType: src.type, | |||
| srcArchiveVersion: srcArchive.version?.replace(/^v/, ''), | |||
| srcArchiveVersion: this._version, // Use the resolved version (e.g. latest -> 27.4.0) | |||
There was a problem hiding this comment.
would be nice if get.docker.com could resolve latest by himself 👀
edit: or at least don't take latest into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the actual version number resolved from the Github releases instead of the
lateststring.