docker/install: Remove deprecated version and channel

Use InstallSource instead Signed-off-by: Paweł Gronowski <[email protected]>
docker · Oct 16, 2024 · 369ee35 · 369ee35
1 parent a39e50f
commit 369ee35
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/__tests__/docker/install.test.itg.ts b/__tests__/docker/install.test.itg.ts
@@ -55,7 +55,11 @@ aarch64:https://cloud.debian.org/images/cloud/bookworm/20231013-1532/debian-12-g
       }
       await expect((async () => {
         const install = new Install({
-          version: version,
+          source: {
+            type: 'archive',
+            version: version,
+            channel: 'stable',
+          },
           runDir: tmpDir,
           contextName: 'foo',
           daemonConfig: `{"debug":true,"features":{"containerd-snapshotter":true}}`

diff --git a/__tests__/docker/install.test.ts b/__tests__/docker/install.test.ts
@@ -40,7 +40,11 @@ describe('download', () => {
   'acquires %p of docker (%s)', async (version, platformOS) => {
     jest.spyOn(osm, 'platform').mockImplementation(() => platformOS as NodeJS.Platform);
     const install = new Install({
-      version: version,
+      source: {
+        type: 'archive',
+        version: version,
+        channel: 'stable',
+      },
       runDir: tmpDir,
     });
     const toolPath = await install.download();

diff --git a/src/docker/install.ts b/src/docker/install.ts
@@ -51,13 +51,6 @@ export type InstallSource = InstallSourceImage | InstallSourceArchive;
 export interface InstallOpts {
   source?: InstallSource;
 
-  // @deprecated
-  // Use `source = InstallSourceTypeArchive{version: ..., channel: ...}` instead
-  version?: string;
-  // @deprecated
-  // Use `source = InstallSourceTypeArchive{version: ..., channel: ...}` instead
-  channel?: string;
-
   // ...
   runDir: string;
   contextName?: string;
@@ -84,8 +77,8 @@ export class Install {
     this.runDir = opts.runDir;
     this.source = opts.source || {
       type: 'archive',
-      version: opts.version || 'latest',
-      channel: opts.channel || 'stable'
+      version: 'latest',
+      channel: 'stable'
     };
     this.contextName = opts.contextName || 'setup-docker-action';
     this.daemonConfig = opts.daemonConfig;