Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lightstreamer image #17145

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

dario-weswit
Copy link
Contributor

No description provided.

@dario-weswit dario-weswit requested a review from a team as a code owner July 9, 2024 14:28
Copy link

github-actions bot commented Jul 9, 2024

Diff for fcd0c5f:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index c2c5284..6d2123c 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -56,22 +56,22 @@ Architectures: amd64, arm64v8
 GitCommit: 3e0e7b00746f56ef7232b68c5e25afa6d688bd7c
 Directory: 7.3/jdk17
 
-Tags: 7.4.2-jdk8-temurin, 7.4-jdk8-temurin, 7-jdk8-temurin, 7.4.2-jdk8, 7.4-jdk8, 7-jdk8
+Tags: 7.4.4-jdk8-temurin, 7.4-jdk8-temurin, 7-jdk8-temurin, 7.4.4-jdk8, 7.4-jdk8, 7-jdk8
 Architectures: amd64, arm64v8
-GitCommit: a5a40050110b2aa65c8ddf1e93db23938e557f1c
+GitCommit: 24200b7179a33ecc040d00cf24e2f6616382ade6
 Directory: 7.4/jdk8
 
-Tags: 7.4.2-jdk11-temurin, 7.4-jdk11-temurin, 7-jdk11-temurin, 7.4.2-jdk11, 7.4-jdk11, 7-jdk11
+Tags: 7.4.4-jdk11-temurin, 7.4-jdk11-temurin, 7-jdk11-temurin, 7.4.4-jdk11, 7.4-jdk11, 7-jdk11
 Architectures: amd64, arm64v8
-GitCommit: a5a40050110b2aa65c8ddf1e93db23938e557f1c
+GitCommit: 24200b7179a33ecc040d00cf24e2f6616382ade6
 Directory: 7.4/jdk11
 
-Tags: 7.4.2-jdk17-temurin, 7.4-jdk17-temurin, 7-jdk17-temurin, 7.4.2-jdk17, 7.4-jdk17, 7-jdk17
+Tags: 7.4.4-jdk17-temurin, 7.4-jdk17-temurin, 7-jdk17-temurin, 7.4.4-jdk17, 7.4-jdk17, 7-jdk17
 Architectures: amd64, arm64v8
-GitCommit: a5a40050110b2aa65c8ddf1e93db23938e557f1c
+GitCommit: 24200b7179a33ecc040d00cf24e2f6616382ade6
 Directory: 7.4/jdk17
 
-Tags: 7.4.2-jdk21-temurin, 7.4-jdk21-temurin, 7-jdk21-temurin, 7.4.2-jdk21, 7.4-jdk21, 7-jdk21, 7.4.2, 7.4, 7, latest
+Tags: 7.4.4-jdk21-temurin, 7.4-jdk21-temurin, 7-jdk21-temurin, 7.4.4-jdk21, 7.4-jdk21, 7-jdk21, 7.4.4, 7.4, 7, latest
 Architectures: amd64, arm64v8
-GitCommit: a5a40050110b2aa65c8ddf1e93db23938e557f1c
+GitCommit: 24200b7179a33ecc040d00cf24e2f6616382ade6
 Directory: 7.4/jdk21
diff --git a/_bashbrew-list b/_bashbrew-list
index 35234e3..2d5cc14 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -65,13 +65,13 @@ lightstreamer:7.4-jdk17
 lightstreamer:7.4-jdk17-temurin
 lightstreamer:7.4-jdk21
 lightstreamer:7.4-jdk21-temurin
-lightstreamer:7.4.2
-lightstreamer:7.4.2-jdk8
-lightstreamer:7.4.2-jdk8-temurin
-lightstreamer:7.4.2-jdk11
-lightstreamer:7.4.2-jdk11-temurin
-lightstreamer:7.4.2-jdk17
-lightstreamer:7.4.2-jdk17-temurin
-lightstreamer:7.4.2-jdk21
-lightstreamer:7.4.2-jdk21-temurin
+lightstreamer:7.4.4
+lightstreamer:7.4.4-jdk8
+lightstreamer:7.4.4-jdk8-temurin
+lightstreamer:7.4.4-jdk11
+lightstreamer:7.4.4-jdk11-temurin
+lightstreamer:7.4.4-jdk17
+lightstreamer:7.4.4-jdk17-temurin
+lightstreamer:7.4.4-jdk21
+lightstreamer:7.4.4-jdk21-temurin
 lightstreamer:latest
diff --git a/lightstreamer_7-jdk11/Dockerfile b/lightstreamer_7-jdk11/Dockerfile
index cef3259..dff6c4e 100644
--- a/lightstreamer_7-jdk11/Dockerfile
+++ b/lightstreamer_7-jdk11/Dockerfile
@@ -12,7 +12,7 @@ RUN apt-get -y update \
 RUN gpg --batch --keyserver hkp://keyserver.ubuntu.com --recv-keys 9B90BFD14309C7DA5EF58D7D4A8C08966F29B4D2
 
 # Set environment variables to identify the right Lightstreamer version and edition
-ENV LIGHTSTREAMER_VERSION 7.4.2
+ENV LIGHTSTREAMER_VERSION 7.4.4
 ENV LIGHTSTREAMER_URL_DOWNLOAD https://lightstreamer.com/distr/ls-server/${LIGHTSTREAMER_VERSION}/Lightstreamer-${LIGHTSTREAMER_VERSION}.tar.gz
 
 # Download the package from the Lightstreamer site, verify the signature, and unpack
diff --git a/lightstreamer_7-jdk17/Dockerfile b/lightstreamer_7-jdk17/Dockerfile
index 683a2c8..d9ef5f7 100644
--- a/lightstreamer_7-jdk17/Dockerfile
+++ b/lightstreamer_7-jdk17/Dockerfile
@@ -12,7 +12,7 @@ RUN apt-get -y update \
 RUN gpg --batch --keyserver hkp://keyserver.ubuntu.com --recv-keys 9B90BFD14309C7DA5EF58D7D4A8C08966F29B4D2
 
 # Set environment variables to identify the right Lightstreamer version and edition
-ENV LIGHTSTREAMER_VERSION 7.4.2
+ENV LIGHTSTREAMER_VERSION 7.4.4
 ENV LIGHTSTREAMER_URL_DOWNLOAD https://lightstreamer.com/distr/ls-server/${LIGHTSTREAMER_VERSION}/Lightstreamer-${LIGHTSTREAMER_VERSION}.tar.gz
 
 # Download the package from the Lightstreamer site, verify the signature, and unpack
diff --git a/lightstreamer_7-jdk8/Dockerfile b/lightstreamer_7-jdk8/Dockerfile
index a98acbc..469b70d 100644
--- a/lightstreamer_7-jdk8/Dockerfile
+++ b/lightstreamer_7-jdk8/Dockerfile
@@ -12,7 +12,7 @@ RUN apt-get -y update \
 RUN gpg --batch --keyserver hkp://keyserver.ubuntu.com --recv-keys 9B90BFD14309C7DA5EF58D7D4A8C08966F29B4D2
 
 # Set environment variables to identify the right Lightstreamer version and edition
-ENV LIGHTSTREAMER_VERSION 7.4.2
+ENV LIGHTSTREAMER_VERSION 7.4.4
 ENV LIGHTSTREAMER_URL_DOWNLOAD https://lightstreamer.com/distr/ls-server/${LIGHTSTREAMER_VERSION}/Lightstreamer-${LIGHTSTREAMER_VERSION}.tar.gz
 
 # Download the package from the Lightstreamer site, verify the signature, and unpack
diff --git a/lightstreamer_latest/Dockerfile b/lightstreamer_latest/Dockerfile
index 1050124..67bef77 100644
--- a/lightstreamer_latest/Dockerfile
+++ b/lightstreamer_latest/Dockerfile
@@ -12,7 +12,7 @@ RUN apt-get -y update \
 RUN gpg --batch --keyserver hkp://keyserver.ubuntu.com --recv-keys 9B90BFD14309C7DA5EF58D7D4A8C08966F29B4D2
 
 # Set environment variables to identify the right Lightstreamer version and edition
-ENV LIGHTSTREAMER_VERSION 7.4.2
+ENV LIGHTSTREAMER_VERSION 7.4.4
 ENV LIGHTSTREAMER_URL_DOWNLOAD https://lightstreamer.com/distr/ls-server/${LIGHTSTREAMER_VERSION}/Lightstreamer-${LIGHTSTREAMER_VERSION}.tar.gz
 
 # Download the package from the Lightstreamer site, verify the signature, and unpack

Relevant Maintainers:

@tianon tianon merged commit 30ded4e into docker-library:master Jul 9, 2024
20 checks passed
@yosifkit
Copy link
Member

It looks like you've updated the download URLs on your servers (to distros/), but the images are still using the old URLs (distr/). So, now when rebuilding for base image updates, all of the lightstreamer images to fail to build because they get a 404 when trying to download the tar.gz file. Can you update all of the relevant Dockerfiles and then provide a PR to update the library/lightstreamer file with the updated references?

Something like this, I think: (I can provide a PR to https://github.com/Lightstreamer/Docker if that's helpful)

- ENV LIGHTSTREAMER_URL_DOWNLOAD https://lightstreamer.com/distr/ls-server/${LIGHTSTREAMER_VERSION}/Lightstreamer-${LIGHTSTREAMER_VERSION}.tar.gz
+ ENV LIGHTSTREAMER_URL_DOWNLOAD https://lightstreamer.com/distros/ls-server/${LIGHTSTREAMER_VERSION}/Lightstreamer-${LIGHTSTREAMER_VERSION}.tar.gz

@dario-weswit
Copy link
Contributor Author

dario-weswit commented Sep 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants