Docs for Liquibase Official Image #1803
Conversation
|
Hi, @tianon ! I am pretty sure there is no newline at the end of content.md. Did I mess it up somehow and I'm not seeing it? Thanks! |
|
Just checked golang/content.md and there are newlines at the end of the file. so, i'm not sure what the issue is here. thanks! |
liquibase/github-repo
Outdated
| @@ -0,0 +1 @@ | |||
| https://github.com/liquibase/docker | |||
There was a problem hiding this comment.
This is the file that's missing a newline at EOF 👀
liquibase/maintainer.md
Outdated
| @@ -0,0 +1 @@ | |||
| ../.common-templates/maintainer-community.md | |||
There was a problem hiding this comment.
This doesn't seem right -- this will give you a generic value of "the Docker Community" where I think it's much more appropriate if this is Liquibase (since the image is upstream-maintained), maybe something like this:
[Liquibase](%%GITHUB-REPO%%)
Co-authored-by: Tianon Gravi <[email protected]>
Co-authored-by: Tianon Gravi <[email protected]>
chore(liquibase): update maintainer information in maintainer.md file
|
It's strange that GitHub doesn't show it in the diff, but it looks like a few more files are missing the newline-at-EOF 👀 (specifically maintainer, license, and content) |
|
@tianon I added the lines and you can see them while editing the file: |
|
@tianon I can see the newlines when editing the file, in my IDE, and in codespaces but not in the github UI for some reason. |
|
i added a space on the newlines and its showing now in the diff |
|
It was successfully green and correct at 80b59f0 😭 I'd suggest cloning locally, and doing |
|
Done @tianon |
Hi! This is doc PR for docker-library/official-images#8409.