Adding verbose option enable on curl. #77
Conversation
Useful for when it is Monday.
|
My PR is only intended for the first commit, not the second.... I think github is getting a little trigger happy...? |
| @@ -398,7 +423,7 @@ query_source_images() { | |||
| for i in ${REPO_LIST} | |||
| do | |||
| # get list of tags for image i | |||
| IMAGE_TAGS=$(curl ${V1_OPTIONS} -sf ${V1_PROTO}://${AUTH_CREDS}@${V1_REGISTRY}/v1/repositories/${i}/tags | jq -r 'keys | .[]') || catch_error "curl => API failure" | |||
| IMAGE_TAGS=$(curl ${V1_OPTIONS} -sf ${V1_PROTO}://${AUTH_CREDS}@${V1_REGISTRY}/v1/repositories/${i}/tags | jq -r 'keys | .[]') || skipping "curl => API failure" "${i}" | |||
There was a problem hiding this comment.
I like the idea of allowing skipping but it would be nice if there was a way to disable skipping of repos since if you're performing a migration, skipping means you're missing data.
There was a problem hiding this comment.
This is in the second commit which I do not want in my PR. Github is trigger happy and taking both my commits. How can I avoid this? Maybe just revert my commit (and/or commit it to a separate branch) so it doesn't get included here?
There was a problem hiding this comment.
Ah yes, I see you've made a commit to your master branch. I'd create a feature branch from your master and then revert your last commit once you've created and checked out the new feature branch.
git branch <my descriptive name>
git reset --hard HEAD~1
You should be able to see in git log that it only includes the first commit then.
Then you can push that branch and you'll need to submit a new PR for the new feature branch.
|
Thanks for the PR! Sorry for taking so long to get back to you on this. Just a few nits since it is changing the current behavior; I think keeping the current behavior to fail on error makes sense while allowing an option to continue on failures. |
Useful for when it is Monday.