This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 125
parser Sscanf and error typos #27
Open
tgrennan
wants to merge
39
commits into
docker-archive:master
Choose a base branch
from
platinasystems:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a spurious println().
Make Code public in the StatusReply
Merge changes from alicebob (method name fix) + dim (pipelining)
Merge storyfeed (added incr, decr, expire, exists and ordered sets)
Fix for Go 1.5+
Ordered sets and some pipeline-related improvements?
Redis really does process each command atomically and sequentially, so this is accurate, and it also protects against racy behaviour involving maps.
…ypo in hvalues check.
Have defaultHandler's DEL function check for brstack keys
Listener automatically starts when a new server is created, and port 0 will make the server use a random available port. Start should be called which will block until the server is closed, and Close() should always be called to clean up and release the port.
"Malformed" not "Mailformed" and %q instead of '%s' Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Devices that are still in the ipv6 duplicated address detection will fail to bind so retry every 100ms for upto 3s. Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Tom Grennan <[email protected]>
Signed-off-by: Kevin Paul Herbert <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that fmt.Sscanf of go1.5 and go1.6 needs "*%d\r\n" for these newline terminated lines.
I also fixed the typos in the Errorf().