feat: add grpc server #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create cargo project - Add tonic & tokio as dependencies - Add services from the protobuf The services are only placeholders, they do not do anything. Signed-off-by: Simon LUCIDO <[email protected]>
2 tasks
RedbeanGit
requested changes
May 30, 2022
| @@ -0,0 +1,14 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Maybe we should create one project per service instead of one big project shared between all teams. @do3-2021/kudo-agent-team, @do3-2021/kudo-cli-team, @do3-2021/kudo-controller-team, @do3-2021/kudo-scheduler-team
There was a problem hiding this comment.
This is a good point. We need to discuss it with everybody on the project. Although we can merge this PR and change directory layout later ?
There was a problem hiding this comment.
There may be quite a few changes once the multi-service organization is defined. I think we need to talk about this BEFORE we merge
lucido-simon
added
enhancement
Change proto filename to be clearer and avoid confusion when merging with other branches. Signed-off-by: Simon LUCIDO <[email protected]>
Signed-off-by: Simon LUCIDO <[email protected]>
|
I think we can close this PR as it's no longer relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues :
Close #24
Overall explanation of your work :
This PR just defines the endpoints ( gRPC service ) declared in the networking's protobuf.
Technical decisions you've made and why :
We use tonic as the gRPC server for its popularity and simple usage.
Tasks lists :