-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mate #2532
base: master
Are you sure you want to change the base?
Mate #2532
Conversation
One can start mate natively using: Or, one can start mate in xiwi using: However, when using xiwi, some desktop items display error dialogs due to differences from mate's 'marco' window manager. This is not an issue when it is started natively using 'startmate'. |
This addresses the request for a mate target: #2520 |
Thanks for this. Hopefully it gets added soon! |
targets/mate
Outdated
CHROOTBIN='crouton-noroot startmate' | ||
. "${TARGETSDIR:="$PWD"}/common" | ||
|
||
if release -lt jessie ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should check should be done prior to installation, like in the e17 target. It looks like you might also need a check for ARM + PPA?
Thanks again. Similar to the LXQT addition, if all the supported releases (wheezy jessie stretch sid kali-rolling precise trusty) and arches (i386, x86_64, arm) aren't covered, there needs to be tests prior to installation. You already have some of the tests, but please make sure everything is there. |
I've added the checks, prior to install, for unsupported arch (arm) and unsupported releases. I tried and failed to squash. I'll try to resolve that. |
OK, I believe I've squashed the commits into a single commit. |
targets/mate
Outdated
|
||
if [ "${TARGETNOINSTALL:-c}" = 'c' ] | ||
if [ "${ARCH#arm}" != "$ARCH" ]; then | ||
error 99 "Mate packages are not available for ARM." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, sorry, I should have realized earlier that Mate isn't available for ARM.
Historically I haven't merged DEs unless they're available on a vast majority of Chromebooks (there's quite a lot of ARM) and on a majority of the supported releases.
I think Mate now squeaks by on the latter point, but I'm extremely hesitant to include something that only works on certain architectures.
@drinkcat @DennisLfromGA thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is Mate available on ARM on later releases?
It's available on arm64 but not arm. The same is true for lxqt, and certain others. But "${ARCH#arm}" != "$ARCH" was wrong. As an aside, there are a few others targets such as chromium are available on arm64 in debian jessie and stretch. It might be worth considering installing on arm64 for those. |
allow install on ARM.
I reread the xfce4 target, and see that xfce4 is available for arm64, armel and armhf, and lxde, lxqt and mate are available for the same -- arm64, armel and armhf. So, the above commit removes the code that excludes the ARM target. |
targets/mate
Outdated
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
if [ "${TARGETNOINSTALL:-c}" = 'c' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be if [ "${TARGETNOINSTALL:-c}" = 'c' ]; then
(bash complains about an unmatched fi
otherwise.)
6f99696
to
a3a39e8
Compare
On xenial, the ppa:ubuntu-mate-dev/xenial-mate repo is added, and Thanks for the help. Please let me know if there are remaining issues. |
|
||
if release -le precise ; then | ||
install software-properties-common | ||
sudo apt-add-repository -y "deb http://packages.mate-desktop.org/repo/ubuntu precise main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script is already run as root, so sudo isn't necessary anywhere in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work with arm on precise?
Sorry for the long delay in replying! |
There are arm binaryies for trusty: On trusty, it allows install on arm now. |
I ran this and #2525 through the autotester, and both had lots of problems across different releases. Here's the test output. If you extract it somewhere and open status.html, you'll see a bunch of red logs, which you can open up and look for more details as to what failed. trusty, for example, seems to be missing /usr/bin/mate-session. |
Any progress on this? I would love a simple way to get Mate |
I know this is old, but there any more progress on this? Like @JaxonWright, I would love Mate in my chroot. |
really all it needs is |
455c029
to
cebf84f
Compare
this adds the target 'mate' consisting of the mate-desktop-environment package, available on most ubuntu releases, and debian jessie and newer.