Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Forms): add support for sessionStorageId in Field.Upload #4424

Merged
merged 7 commits into from
Dec 26, 2024
Merged

fix(Forms): add support for sessionStorageId in Field.Upload #4424

merged 7 commits into from
Dec 26, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Dec 20, 2024 •
edited
Loading

In this PR #4339 we did not render the stored files.
This time, we do support rendering the file names stored in the session storage. The test dedicated to session storage got aligned.

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 8:37pm

@tujoworker tujoworker marked this pull request as ready for review December 20, 2024 20:18
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 20, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

langz
langz approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄🎅

@langz
Copy link
Contributor

langz commented Dec 20, 2024

Do you think we should release it now?
v10.62.1? Or wait to after the holidays?

@tujoworker
Copy link
Member Author

I think we should first look into Value.Upload and add support for it there as well.

@langz
Update packages/dnb-design-system-portal/src/docs/uilib/extensions/fo…
4efc7e2 
…rms/feature-fields/more-fields/Upload/info.mdx
@langz langz merged commit a8dfc52 into main Dec 26, 2024
9 of 10 checks passed
@langz langz deleted the fix/forms-upload-session-storage branch December 26, 2024 20:34
tujoworker pushed a commit that referenced this pull request Dec 27, 2024
@semantic-release-bot
chore(release): 10.62.1 [skip ci]
3ff159d 
## [10.62.1](v10.62.0...v10.62.1) (2024-12-27)

### 🐛 Bug Fixes

* **Forms:** add support for `sessionStorageId` in Field.Upload ([#4424](#4424)) ([a8dfc52](a8dfc52)), closes [#4339](#4339)
* **Forms:** correct font-size of non-clickable Field.Upload item ([#4425](#4425)) ([74423d6](74423d6))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.62.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tujoworker @langz