-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Forms): add support for conditional function based info
, warning
and error
props to all Field.*
components
#4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
2 times, most recently
from
December 20, 2024 12:09
340f89a
to
7186ba7
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
December 20, 2024 13:04
7186ba7
to
c47a0b3
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 6, 2025 08:08
c47a0b3
to
31fd2bf
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
2 times, most recently
from
January 6, 2025 10:45
d2af256
to
8ceef20
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 6, 2025 14:21
94df92f
to
7516bef
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 6, 2025 19:47
7516bef
to
caf1f74
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 6, 2025 21:12
caf1f74
to
9a3c8ff
Compare
langz
reviewed
Jan 7, 2025
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/base-fields/Number/demos.mdx
Outdated
Show resolved
Hide resolved
langz
reviewed
Jan 7, 2025
packages/dnb-eufemia/src/extensions/forms/hooks/useFieldProps.ts
Outdated
Show resolved
Hide resolved
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
3 times, most recently
from
January 7, 2025 10:33
11959df
to
d4f2f6c
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 7, 2025 12:40
d4f2f6c
to
645a24b
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
3 times, most recently
from
January 13, 2025 08:18
88103c6
to
724b68b
Compare
…ing` and `error` props to all `Field.*` components
Co-authored-by: Anders <[email protected]>
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 13, 2025 10:05
a04caea
to
3c8bb77
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 13, 2025 13:02
98479d8
to
16db283
Compare
tujoworker
force-pushed
the
feat/forms-conditional-infos
branch
from
January 13, 2025 13:04
16db283
to
a83e86b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the
info
,warning
, anderror
props to accept functions. This makes it easier to create conditional messages without relying on making a field "controlled."Additionally, it ensures the same user experience for displaying these messages (by using the
conditionally
function), consistent with how error messages are handled by default today.Here's an example.