release of v10.60 #4361
Merged
release of v10.60 #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forward the props to HeightAnimation, so we just need the types and the docs to make this work. Maybe we should call it `onVisible`? But on the other hand, it's meant to be used only when `animate` is set to true. --------- Co-authored-by: Anders <[email protected]>
I think we should use `onVisible` for both the animated and non-animated state change. Here is the related PR #4350 While `onAnimationEnd` should be used to determine if the animated has "ended". Pretty much like HeightAnimation works. --------- Co-authored-by: Anders <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
The reason behind this is that I saw a negative side-effect in PR #4357 when it comes to the initial render, where we don't want an animation, but it did animate.
- Change `playwright.config.ts` so it runs locally on post 8000. - Copy fonts folder in /public directory so it can be used by third party apps without getting hashed. - Document the hosted fonts on [this page](https://eufemia-git-feat-font-cdn-eufemia.vercel.app/uilib/typography/) (could not find a better place, any better ideas out there?). - Added a e2e test to verify the fonts are located properly. - Moved `Typography.e2e.spec.ts` from the Portal workspace to the Eufemia Workspace, because I think it's the correct place.
…t), or custom messages to users (#4357) PR [Preview](https://eufemia-git-feat-forms-status-eufemia.vercel.app/uilib/extensions/forms/Form/InfoOverlay/). --------- Co-authored-by: Anders <[email protected]>
This only adds the "sync" onFileClick event. Not support for async yet. Not really sure how the loading state of a Value.Upload with async onFileClick would look 🤔 Can be demoed here: https://eufemia-git-feat-upload-value-on-file-click-eufemia.vercel.app/uilib/extensions/forms/Value/Upload/demos/#using-onfileclick --------- Co-authored-by: Tobias Høegh <[email protected]>
Removes the warning:
```
Eufemia Icon required: A Tertiary Button requires an icon to be WCAG compliant in most cases, because variant tertiary has no underline.
(Override this warning using icon={false}, or consider using one of the other variants)
```
…`direction="bottom"` usage, including when used in a Dialog component (#4368) - Failing [CSB](https://codesandbox.io/p/sandbox/crimson-sunset-5wwngy?file=/src/App.tsx:3,1-3,39). - Working [CSB](https://codesandbox.io/p/sandbox/pensive-rain-97s4r3?file=/src/App.tsx:11,3-31,14&workspaceId=ws_LdVovV1oCo5S5p2KEnsf6m).
tujoworker
approved these changes
Dec 10, 2024
|
🎉 This PR is included in version 10.60.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.