Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release of v10.56 #4257

Merged
merged 35 commits into from
Nov 18, 2024
Merged

release of v10.56 #4257

merged 35 commits into from
Nov 18, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Nov 11, 2024

No description provided.

joakbjerk and others added 4 commits November 11, 2024 12:28
)

As of today the following elements DL, UL, OL [say they have
support](https://eufemia.dnb.no/uilib/elements/lists/properties/#ol-properties)
for skeleton and skeletonMethod, but they don't as they internally in
the component/element set skeleton to false(`skeleton=false`).

This PR removes docs and type support for skeleton(as it is not actually
supported) in:
- Dl
- Ul
- Ol
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 6:57am

Copy link

codesandbox-ci bot commented Nov 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

langz and others added 3 commits November 13, 2024 10:57
This is not correct/finished.

The motivation behind this change is that when reading the
[description](https://eufemia.dnb.no/uilib/extensions/forms/Form/Appearance/info/#description),
I don't easily understand which Field.X-components I can use or not with
the `Form.Appearance`.

The description doesn't use commonly known names in the forms world as
base fields or feature fields, etc, but it rather says `provides theming
of sizes of input fields, including Autocomplete and Dropdown`,
thoughts:
- What's input fields?
- Why do we mention the base Eufemia component Autocomplete, instead of
the Field equivalent?
- Why do we mention the base Eufemia component Dropdown, instead of the
Field equivalent?

---------

Co-authored-by: Tobias Høegh <[email protected]>
…those with snake case (#4273)

Co-authored-by: Tobias Høegh <[email protected]>
Co-authored-by: Anders <[email protected]>
Co-authored-by: Joakim Bjerknes <[email protected]>
Co-authored-by: Tobias Høegh <[email protected]>
whitneymarkov and others added 3 commits November 17, 2024 23:26
…file handling during upload (#4281)

Add support for asynchronously processing/handling files so a virus
checker can be used with the Field.Upload component.

---------

Co-authored-by: Whitney Hiltz <[email protected]>
…lt (with option to open in Dialog) (#4282)

This PR changes the existing behavior of the `help` prop for Fields that
previously supported it. The content now opens inline instead of in a
Dialog.

The `help` prop has now all of these optional props:

```tsx
<Field.String
  label="Label text"
  help={{
    title: 'Help is available',
    content:
      'Take the time to help other people without expecting a reward or gratitude is definitely important in living an optimistic life.',
    open: false,// only for the inline variant
    renderAs: 'dialog'
  }}
/>
```

We use this prop description:

> Provide help content for the field using `title` and `content` as a
string or React.Node. Additionally, you can set `open` to `true` to
display the inline help or use `renderAs` set to `dialog` to render the
content in a [Dialog](/uilib/components/dialog/) (recommended for larger
amounts of content).
 
Examples with inline "HelpButton":

-
[FieldBlock](https://eufemia-git-feat-forms-inline-help-button-eufemia.vercel.app/uilib/extensions/forms/create-component/FieldBlock/demos/#inline-help-button-vertical-only)
(several examples)
-
[Form.MainHeading](https://eufemia-git-feat-forms-inline-help-button-eufemia.vercel.app/uilib/extensions/forms/Form/MainHeading/#with-helpbutton)
-
[Form.SubHeading](https://eufemia-git-feat-forms-inline-help-button-eufemia.vercel.app/uilib/extensions/forms/Form/SubHeading/#with-helpbutton)
-
[Field.String](https://eufemia-git-feat-forms-inline-help-button-eufemia.vercel.app/uilib/extensions/forms/base-fields/String/#with-help)
-
[Field.Number](https://eufemia-git-feat-forms-inline-help-button-eufemia.vercel.app/uilib/extensions/forms/base-fields/Number/#with-help)
-
[Field.Upload](https://eufemia-git-feat-forms-inline-help-button-eufemia.vercel.app/uilib/extensions/forms/feature-fields/more-fields/Upload/#with-help)
- ... many other fields do have an example as well.

**NB:** We do not document the internals of the inline version at this
time. This can be included in another PR. The reason is that it would
require additional tests, examples, and documentation. It is also an
"isolated" feature specific to the HelpButton. However, as of this
writing, I am unsure if we will ever document it, as integration is not
straightforward. There are several considerations to address when
implementing it.
langz and others added 2 commits November 18, 2024 07:44
- [x] Add documentation
- [x] Add some tests
- [x] Double check if any of the props needs accommodate for field props
- [x] Fix startMonth and endMonth bugs
- [x] Fix date correction test
- [x] Merge `DatePicker` camelCase changes

---------

Co-authored-by: Tobias Høegh <[email protected]>
Co-authored-by: Anders <[email protected]>
@langz langz merged commit f62c02b into release Nov 18, 2024
8 of 9 checks passed
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants