Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons): add browser, digipass, envelope_open, laptop, mobile, money_left, teenager #3064

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 12, 2023

This PR adds the following icons:

  • browser
  • digipass_corporate
  • digipass_private
  • envelope_open
  • laptop
  • mobile
  • money_left
  • teenager

Can be demoed here https://eufemia-git-icons-update-dec-23-eufemia.vercel.app/icons/#undefined
Should we add these icons to a "category"(Objects, Essentials, Actions, etc)?
I see that they are categorized as undefined for now.

But in the Figma Library it seems like digipass icons, etc, should be listed under the category Objects 🤔

…oins_1_medium.svg, eufemia-icons-xml-categorized.tgz, eufemia-icons-xml.tgz, scan.svg, scan_medium.svg, version.lock, coins_1.tsx, coins_1_medium.tsx, icons-svg.lock, index.ts, scan.tsx, scan_medium.tsx, secondary_icons.ts, secondary_icons_medium.ts, icons-meta.json, index.ts, browser.svg, browser_medium.svg, digipass_corporate.svg, digipass_corporate_medium.svg, digipass_private.svg, digipass_private_medium.svg, envelope_open.svg, envelope_open_medium.svg, laptop.svg, laptop_medium.svg, mobile.svg, mobile_medium.svg, money_left.svg, money_left_medium.svg, teenager.svg, teenager_medium.svg, browser.ts, browser_medium.ts, digipass_corporate.ts, digipass_corporate_medium.ts, digipass_private.ts, digipass_private_medium.ts, browser.tsx, browser_medium.tsx, digipass_corporate.tsx, digipass_corporate_medium.tsx, digipass_private.tsx, digipass_private_medium.tsx, envelope_open.tsx, envelope_open_medium.tsx, laptop.tsx, laptop_medium.tsx, mobile.tsx, mobile_medium.tsx, money_left.tsx, money_left_medium.tsx, teenager.tsx, teenager_medium.tsx, envelope_open.ts, envelope_open_medium.ts, laptop.ts, laptop_medium.ts, mobile.ts, mobile_medium.ts, money_left.ts, money_left_medium.ts, teenager.ts, teenager_medium.ts
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 7:58pm

@langz langz changed the title feat(Icons): add [icon names] feat(Icons): add browser, digipass, envelope_open, laptop, mobile, money_left, teenager Dec 12, 2023
Copy link

codesandbox-ci bot commented Dec 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 214f7fd:

Sandbox Source
eufemia-starter Configuration

@langz
Copy link
Contributor Author

langz commented Dec 12, 2023

Updating visual/screenshots now 🕐

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We need to update the visual snapshot locally. We may add back this features to be automatically generated, if you want. Just updating icon is 👍

It looks like the tag we removed last time, is still in the Figma file 🤔

Screenshot 2023-12-12 at 15 17 30

@langz
Copy link
Contributor Author

langz commented Dec 12, 2023

Looks good! We need to update the visual snapshot locally. We may add back this features to be automatically generated, if you want. Just updating icon is 👍

It looks like the tag we removed last time, is still in the Figma file 🤔

Screenshot 2023-12-12 at 15 17 30

I've updated the visual snapshots now.
I did not find the word recieve in the Figma library, so it's probably hiding somewhere 🤔 😂

@tujoworker
Copy link
Member

I'v added a timeout on this GitHub Action. If you want, move it to a new PR. Or just keep it there 👍

Screenshot 2023-12-12 at 20 45 39

@langz langz merged commit b503e36 into main Dec 15, 2023
11 of 12 checks passed
@langz langz deleted the icons/update-dec-23 branch December 15, 2023 11:46
@langz langz mentioned this pull request Dec 15, 2023
tujoworker pushed a commit that referenced this pull request Jan 4, 2024
## [10.16.0](v10.15.1...v10.16.0) (2024-01-04)

### 📝 Documentation

* **Field.PhoneNumber:** document event handlers argument value ([#3063](#3063)) ([b6baeb7](b6baeb7))
* remove colon in examples and add info about colon usage in labels for form elements ([#3167](#3167)) ([04d1e64](04d1e64))

### 🐛 Bug Fixes

* **Anchor:** dnb-anchor--no-hover and dnb-anchor--contrast ([#3139](#3139)) ([b718350](b718350))
* **Anchor:** remove icon when dnb-anchor--no-icon ([#3138](#3138)) ([83c1b47](83c1b47))
* **DatePicker:** make sure calendar shows correct date on date prop update ([#3112](#3112)) ([b571962](b571962))
* **Field.Date:** define empty value to trigger required error ([#3017](#3017)) ([45b4667](45b4667))
* **Field.Expiry:** handles value as null ([#3143](#3143)) ([2a5fd66](2a5fd66))
* **Field.Expiry:** should handle values of non existing months ([#3144](#3144)) ([13cdc9f](13cdc9f))
* **Field.PhoneNumber:** make country code only search for country name based on chosen locale ([#3156](#3156)) ([26c4f20](26c4f20))
* **Field.PhoneNumber:** renders an validation error initially when it is required and only country code is provided ([#3081](#3081)) ([0d1063a](0d1063a))
* **Field.Selection:** add error state and message ([#3077](#3077)) ([06de7c9](06de7c9))
* **Field.Selection:** fix Dropdown width ([#3136](#3136)) ([2fb7e47](2fb7e47))
* **Field.Selection:** make it possible to disable radio variants ([#3086](#3086)) ([980cabd](980cabd))
* **Field.String:** validated empty value when required ([#3125](#3125)) ([541c9b1](541c9b1))
* **forms:** update data context with initially given field value ([#3135](#3135)) ([93d08e6](93d08e6))
* **PhoneNumber:** make long labels wrap nicely ([#3066](#3066)) ([d12850d](d12850d))
* **Radio:** fix correct spacing between label/legend and fieldset ([#3115](#3115)) ([9dc7d9e](9dc7d9e))
* **Section:** ensure overlay is behind content ([#3141](#3141)) ([53346ec](53346ec))
* **StepsLayout:** mode defaults to strict ([#3145](#3145)) ([eef4744](eef4744))
* **StepsLayout:** prevent component adjust to screen size on mobile ([#3146](#3146)) ([20d92d2](20d92d2))
* **ToggleButton:** align label position ([#3169](#3169)) ([22f587d](22f587d))
* **Tooltip:** text alignment for short text ([#3084](#3084)) ([7b83a7a](7b83a7a))
* **Upload:** omit FormEvent onChange type ([#3113](#3113)) ([52e42c2](52e42c2))

### ✨ Features

* **Card:** responsive breakout on small screens ([#3163](#3163)) ([da88ac9](da88ac9))
* **Email:** trim value ([#3170](#3170)) ([ea56957](ea56957)), closes [#3165](#3165)
* **Icons:** add browser, digipass, envelope_open, laptop, mobile, money_left, teenager ([#3064](#3064)) ([b503e36](b503e36))
* **InputMasked:** enhance inputMode for better support of showing correct soft keyboards ([#3108](#3108)) ([e95ef1f](e95ef1f)), closes [#3097](#3097)
* **String:** add `capitalize` prop ([#3159](#3159)) ([3dce145](3dce145))
* **useDataValue:** add toOutput, fromExternal and validateRequired ([#3109](#3109)) ([cf04125](cf04125))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants