-
Notifications
You must be signed in to change notification settings - Fork 60
Add Windows Support to tensorboard #27
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
|
||
```bash | ||
C:\>cd tensorboard | ||
C:\tensorboard>bash installer.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
cd tensorflow | ||
|
||
# run configuration. | ||
bash configure --prefix=/mingw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why prefix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This the only thing worked with me. Without this, I got bazel build errors.
See Reference
@@ -183,7 +183,7 @@ def image(tag, tensor): | |||
def make_image(tensor, height, width, channel): | |||
"""Convert an numpy representation image to Image protobuf""" | |||
image = Image.fromarray(tensor) | |||
output = StringIO.StringIO() | |||
output = StringIO() # This is working for python 2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this? Any error in the origin code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use python 2.7 and it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using Anaconda python 2.7. I got errors with this error AttributeError: class StringIO has no attribute 'StringIO'
When I made the modification, it is working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me test this in my env, thanks.
Is the binary and |
@zihaolucky
So, I added the binary files explicitly for reference on github. If someone needs to verify the installation (without going the whole path). |
cp -r ../tools/* bazel-bin/tensorflow/tools/ | ||
|
||
# get .whl file in python/dist/ | ||
bash bazel-bin/tensorflow/tools/pip_package/build_pip_package.sh ../python/dist/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In build_pip_package.sh
, .runfiles
in Windows are placed in a different location. But I forgot to handle this in tensorboard-binary.patch
, could you take a look? Just take a look at the tensorboard
binary and try to handle runfiles location in FindModuleSpace
.
@ahmedezzateasa Let me check the latest |
No description provided.