Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove registry clean_string hack (nushell#10804)
# Description Remove the `clean_string` hack used in `registry query`. This was a workaround for a [bug][gentoo90/winreg-rs#52] in winreg which has since [been fixed][edf9eef] and released in [winreg v0.12.0]. winreg now properly displays strings in RegKey's Display impl instead of outputting their debug representation. We remove our `clean_string` such that registry entries which happen to start/end with `"` or contain `\\` won't get mangled. This is very important for entries in UNC path format as those begin with a double backslash. [gentoo90/winreg-rs#52]: <gentoo90/winreg-rs#52> [edf9eef]: <gentoo90/winreg-rs@edf9eef> [winreg v0.12.0]: <https://github.com/gentoo90/winreg-rs/releases/tag/v0.12.0> # User-Facing Changes - `registry query` used to accidentally mangle values that contain a literal `\\`, such as UNC paths. It no longer does so. # Tests + Formatting - [X] `toolkit check pr` - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib`
- Loading branch information