-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gemfile.d for upstream CI #116
Conversation
This approach looks simpler/cleaner - let's see what the pipeline says. |
The gemspec shouldn't contain environment variables, because it's also used in other contexts where it could break. In common CI we read gemfile.d/*.rb so this is the best place for bundler overrides. Fixes: 3eedb81 ("feat(actions): switch to upstream CI templates (dm-drogeriemarkt#113)")
I failed rubocop. Now updated |
Now failing due to theforeman/foreman-js#477 / theforeman/foreman#10116. |
We literally just now discussed it for 3.9, but 3.7 & 3.8 are EOL and I don't think we'll update those anymore. There certainly won't be any more releases. |
@laugmanuel since current master will also fail on the same thing, should this be merged? |
I guess we need to drop tests for that Foreman version then. I'll prepare a PR for that.
Let's wait until old versions are dropped from CI. |
Do cherry picks of theforeman/foreman@7008091, which is being worked on. |
Thanks @ekohl |
The gemspec shouldn't contain environment variables, because it's also used in other contexts where it could break.
In common CI we read
gemfile.d/*.rb
so this is the best place for bundler overrides.Fixes: 3eedb81 ("feat(actions): switch to upstream CI templates (#113)")
I'm not 100% sure this works, but if it does then I'll document it as a recommended approach.