Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop python 3.8, enable python 3.13, and enable full linting for 3.12 #2194

Merged
merged 14 commits into from
Jan 12, 2025
Merged

drop python 3.8, enable python 3.13, and enable full linting for 3.12 #2194

merged 14 commits into from
Jan 12, 2025

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Jan 7, 2025 •
edited
Loading

Description

This PR does the following:

  • Drop support for python3.8, also removes all special code and dependencies we added for pyhton3.8
  • Enable linting for python3.12, all extras are now supported on python3.12
  • Enable python3.13 and run common tests there. Use dlt-pendulum for now.

Based on #2047

ToDo:

  • Should dlt-pendulum be on our private pypi?

@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 391785c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6780d84de6fb5c00083d028e

@sh-rp sh-rp force-pushed the tmp/test_py_versions branch 3 times, most recently from 368e04d to d0de684 Compare January 8, 2025 10:16
@sh-rp sh-rp changed the title [do not merge] test python versions [do not merge] pin poetry 1.8.5 and enable linting for python 3.12 Jan 8, 2025
@sh-rp sh-rp changed the title [do not merge] pin poetry 1.8.5 and enable linting for python 3.12 pin poetry 1.8.5 and enable linting for python 3.12 Jan 8, 2025
@sh-rp sh-rp force-pushed the tmp/test_py_versions branch from d0de684 to 8cc3b7a Compare January 8, 2025 10:27
@sh-rp sh-rp changed the title pin poetry 1.8.5 and enable linting for python 3.12 drop python 3.8, enable python 3.13 and enable linting and common tests for 3.12 3.13 Jan 8, 2025
@sh-rp sh-rp changed the title drop python 3.8, enable python 3.13 and enable linting and common tests for 3.12 3.13 drop python 3.8, enable python 3.13 and enable linting and common tests for 3.12, 3.13 Jan 8, 2025
@sh-rp sh-rp force-pushed the tmp/test_py_versions branch 2 times, most recently from 5e4f829 to fc4006c Compare January 8, 2025 16:20
sh-rp
sh-rp commented Jan 8, 2025
View reviewed changes
pyproject.toml Show resolved Hide resolved
@sh-rp sh-rp force-pushed the tmp/test_py_versions branch 2 times, most recently from 7f22437 to e46f21c Compare January 8, 2025 18:15
@sh-rp sh-rp changed the title drop python 3.8, enable python 3.13 and enable linting and common tests for 3.12, 3.13 drop python 3.8, enable python 3.13, and enable full linting for 3.12 Jan 9, 2025
@sh-rp sh-rp marked this pull request as ready for review January 9, 2025 11:15
sh-rp
sh-rp commented Jan 9, 2025
View reviewed changes
.github/workflows/lint.yml
@@ -26,7 +26,7 @@ jobs:
matrix:
os:
- ubuntu-latest
python-version: ["3.8.x", "3.9.x", "3.10.x", "3.11.x"]
python-version: ["3.9.x", "3.10.x", "3.11.x", "3.12.x"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make dev works for 3.12 now!

rudolfix
rudolfix previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just resolve all the conflicts...

@sh-rp sh-rp force-pushed the tmp/test_py_versions branch from cca2c57 to b3372de Compare January 9, 2025 15:32
sh-rp
sh-rp commented Jan 9, 2025
View reviewed changes
Makefile Show resolved Hide resolved
@sh-rp sh-rp mentioned this pull request Jan 10, 2025
Closed
@rudolfix rudolfix merged commit cbcff92 into devel Jan 12, 2025
59 of 60 checks passed
@rudolfix rudolfix deleted the tmp/test_py_versions branch January 12, 2025 15:40
@rudolfix rudolfix mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh-rp @rudolfix