Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct README for 80/zm port map #138

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Correct README for 80/zm port map #138

merged 3 commits into from
Nov 23, 2020

Conversation

Tony763
Copy link
Contributor

@Tony763 Tony763 commented Nov 23, 2020

Address issue #137

@PrplHaz4
Copy link
Contributor

This is not the correct place to change it - you are changing the actual docker command, and tcp tells it to forward tcp packets into the container on port 80. Your edit would likely break people's installations.

I believe the part you really want to update is in the "Usage" section.

@dlandon dlandon merged commit c055022 into dlandon:master Nov 23, 2020
@Tony763 Tony763 deleted the patch-1 branch November 24, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tony763 @PrplHaz4 @dlandon