Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI #82

Closed
wants to merge 1 commit into from
Closed

Travis CI #82

wants to merge 1 commit into from

Conversation

dustalov
Copy link

@dustalov dustalov commented Oct 5, 2017

Hello!

I have added the support for Travis CI builds against different versions of JDK. I believe this will simplify further improvements of DKPro WSD.

Build Status

Among other things, this pull request includes two workarounds:

  • The test de.tudarmstadt.ukp.dkpro.wsd.io.reader.AidaReaderTest has been disabled due to the known bug reported before. It can be enabled and reproduced by removing the sed command from .travis.yml.
  • Prior to running the tests, the opennlp:maxent:2.5.1 module is downloaded and installed. If possible, could you please upload it to your Maven repository?

Please do not hesitate writing to me regarding this PR.

@reckart
Copy link
Member

reckart commented Oct 5, 2017

We already do have a Jenkins CI build for DKPro WSD: https://zoidberg.ukp.informatik.tu-darmstadt.de/jenkins/job/DKPro%20WSD%20(GitHub)/

@reckart
Copy link
Member

reckart commented Oct 5, 2017

I'm not familiar with there opennlp maxent 2.5.1 is used, but the better option would be to upgrade to OpenNLP 1.8.2 (the separate maxent artifact afaik doesn't exist anymore).

@logological
Copy link
Member

I'm not familiar with there opennlp maxent 2.5.1 is used, but the better option would be to upgrade to OpenNLP 1.8.2 (the separate maxent artifact afaik doesn't exist anymore).

This is Issue #81. The repository containing that artifact is gone and I can't find any other copy. Upgrading OpenNLP is nontrivial as the API has changed. I have disabled the IMS code in the meantime in hopes of getting DKPro WSD to successfully build once again.

@ukp-svc-jenkins
Copy link

Can one of the admins verify this patch?

@dustalov
Copy link
Author

I propose to close this PR due to the massive move to GitHub Actions.

@dustalov dustalov closed this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants