Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#241 Update dependency Spring to version 6.x #253

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mawiesne
Copy link
Contributor

  • sets the compiler level to 17 to comply with Spring 6.x requirements
  • updates Spring dependencies to version 6.0.13
  • adds necessary references to spring-context in wikimachine pom.xml
  • removes reference to XmlBeanFactory in SpringFactory as this interface was long-time deprecated and removed in Spring 6.x

- sets the compiler level to `17` to comply with Spring 6.x requirements
- updates Spring dependencies to version 6.0.13
- adds necessary references to `spring-context` in wikimachine pom.xml
- removes reference to `XmlBeanFactory` in `SpringFactory` as this interface was long-time deprecated and removed in Spring 6.x
@mawiesne mawiesne requested a review from rzo1 October 30, 2023 12:25
@mawiesne mawiesne self-assigned this Oct 30, 2023
@mawiesne mawiesne added the dependencies Pull requests that update a dependency file label Oct 30, 2023
@mawiesne mawiesne added this to the 2.0.0 milestone Oct 30, 2023
@mawiesne
Copy link
Contributor Author

mawiesne commented Oct 30, 2023

Sry for the new PR instead of #242 (closed by branch handling automatically?).
Github & IDE had some trouble understanding each other ... -.-

For previous discussion see #242.

@mawiesne mawiesne requested a review from reckart October 30, 2023 12:27
@mawiesne
Copy link
Contributor Author

mawiesne commented Oct 30, 2023

Ping @reckart - we landed in this PR now. It brings the minimal compiler level for JWPL to 17, as proposed / discussed.

Once you agree, we can make progress and you should be ready to roll the 2.0.0 release.

Copy link
Member

@reckart reckart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@mawiesne mawiesne merged commit f887d77 into master Oct 30, 2023
4 checks passed
@mawiesne mawiesne deleted the #241-update-dependency-Spring-to-version-6.x branch October 30, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants