#243 Update test framework JUnit to 5.x #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mawiesne
commented
Oct 29, 2023
mawiesne
commented
- updates to JUnit 5.10.x
- adapts existing test classes to new package names and test concepts of JUnit 5
mawiesne
changed the title
mawiesne
changed the title
rzo1
approved these changes
Oct 29, 2023
mawiesne
added
🆕Enhancement
dependencies
|
Ping @reckart. Please signal if you agree with this PR. |
reckart
reviewed
Oct 30, 2023
There was a problem hiding this comment.
Thanks for the PR - great work!
Please avoid defining dependency scopes in the dependencyManagement sections.
It should not be necessary to have a hard dependency on the jupiter engine (tests should only depend on the API) - rather if necessary, it should be a dependency of the surefire plugin.
will check this. |
mawiesne
force-pushed
the
#243-update-test-framework-JUnit-to-5.x
branch
from
ffddeef to
4a8a4e5
Compare
- updates to JUnit 5.10.x - adapts existing test classes to new package names and test concepts of JUnit 5
mawiesne
force-pushed
the
#243-update-test-framework-JUnit-to-5.x
branch
from
4a8a4e5 to
6199cd7
Compare
|
@reckart I reworked the PR towards your comments. I think, it should be fine now. |
|
@mawiesne feel free to merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.