-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow form elements visibility #4
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # nexusdialog/src/main/java/com/github/dkharrat/nexusdialog/controllers/LabeledFieldController.java
Thanks for your contribution! I'm reviewing the code changes, but would you please squash the commits into one? I'll add my comments once that's done. Thanks. |
@Rodolfocartas any update on your branch? |
…icker Optionally show time picker dialog after date picker
When this PR will be merged? |
@dneykov: It hasn't been merged yet because I haven't received an update from @Rodolfocartas regarding my comments. In any case, it's likely that this PR is out-of-sync with master, so it might have to be re-implemented. If you need this functionality, one way to get it is to do it on the |
Thanks for your quick response. I will take your suggestions. |
@dkharrat When I try to access the view is giving an error: Here is what I'm trying:
Thanks |
@dneykov you're getting this crash due to the view not being completely initialized yet. They are initialized once the
Hope this helps. I think it would be useful to get this hide/show functionality builtin to the library. I'll look into implementing it soon. |
I've added the ability to hide elements and sections.