Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player.colour console command #3728

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

player.colour console command #3728

wants to merge 4 commits into from
+116 −84

Conversation

AdamPlenty
Copy link
Contributor

Resolves #3725

@AdamPlenty AdamPlenty marked this pull request as ready for review November 27, 2024 05:18
PieterVdc
PieterVdc requested changes Dec 1, 2024
View reviewed changes
Copy link
Member

@PieterVdc PieterVdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned on the discord, I do not believe this should have a packet, the player action is sending the chat, which should already be in one

@AdamPlenty
Copy link
Contributor Author

as mentioned on the discord, I do not believe this should have a packet, the player action is sending the chat, which should already be in one

If this is the case, then surely we don't need the dirty hacks, either?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PieterVdc PieterVdc PieterVdc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console command to switch player color
2 participants
@AdamPlenty @PieterVdc