position tool tips correctly #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool Tips are positioned according to the mouse X and Y coordinate. A y-offset of 86 was added, which was correct for 640x400. This fixed 86 has now been replaced with a value based on the units_per_pixel value. This means that the tool tip is now in the correct position at all resolutions.
in calculating y_offset, now accounts correctly for rounding
Loobinex
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1003
Tool Tips are positioned according to the mouse X and Y coordinate. A y-offset of 86 was added, which was correct for 640x400.
This fixed 86 has now been replaced with a value based on the units_per_pixel value. This means that the tool tip is now in the correct position at all resolutions.
Instead of this:
we now have this:
