Split properties into new PropertyCache
#413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the properties from the `EffectCache` and move their resource management into a new `PropertyCache`, which allocates GPU buffers to store them. This clarifies ownership, and allows better batching (in theory) as not all effects use properties. In this change, unfortunately for simplicity we directly store the offset into the property buffer for each instance into the effect batch, meaning we again block batching multiple effects. This is hopefully temporary (and not the only blocker, so doesn't introduce any regression), but makes the change incremental and easier to handle for now, while other clean-ups are still pending.
djeedai
added
C - enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the properties from the
EffectCacheand move their resource management into a newPropertyCache, which allocates GPU buffers to store them. This clarifies ownership, and allows better batching (in theory) as not all effects use properties.In this change, unfortunately for simplicity we directly store the offset into the property buffer for each instance into the effect batch, meaning we again block batching multiple effects. This is hopefully temporary (and not the only blocker, so doesn't introduce any regression), but makes the change incremental and easier to handle for now, while other clean-ups are still pending.