Massive overhaul #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Monkey patch if ActiveSupport is defined Reformated code
Minor updates from @seuros, a little bit of cleanup. Looking good, tests pass!
[#2] Add license to gemspec, is GPLv2
Specified `path` option for `xmlrpc.php` not on root directory. Also, clarified a little bit on the text.
Added :filename to uploadFile, so you only give a valid filename. See #7
added :filename to uploadFile
Revert "Support version 1.9.2 in tests"
…e ssl port, updating README with ssl example, and removing the gem file from the repository
PR for issue 28
cleaning up the README and adding a couple of examples
new uploadFile patch
fix - skip '})' in source demo uploading file
So it can be modified if necessary, eg. to disable SSL verification.
Cache the created XMLRPC connection
VCR has a capability to calculate the response content length at the time of the cassette playback. This allows changes to the recording without having to constantly update the information to match the body length. Update the VCR setup code to utilize this mechanism for each cassette playback.
Add support for wordpress sites that require a particular cookie(s) in order to be accessible. For example, this could happen on a company intranet where the SSO mechanism does not support basic authorization. Update client to accept an additional cookie value and pass that along to the underlying connection when it is set. This fixes issue #36.
This is a simple change to the spec_helper to allow setting a custom port and whether to use SSL on the underlying XML-RPC client. The README and sample .env file are updated accordingly.
This allows bare method names to be passed to Client#execute and be prefixed by "wp." as before, but allows method names with a namespace prefix to pass through unmodified. This is determined by whether or not there is a '.' present in the method name. This implementation does mean that custom methods must have some dotted prefix, since any bare method names are assumed to need "wp.", but this seems to be a reasonable requirement, matching API convention.
Fix #38 - Allow tests to run against HTTPS servers
Fix #37 - Allow custom prefixes on method names
Add support for cookie based authentication mechanisms
Catch 'Errno::EPIPE: Broken pipe' and reconnect.
[#46] - Fix getPostStatusList
* Add configurable timeouts * Add tests
* Added xmlrpc dependency for ruby >= 2.4.0 support * Version bump to 1.2.2 * Updated contributors list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Daniel, here's what I've done:
I know that you wanted tests for everything, but considering I added the entire API to spec, I haven't gotten around to writing the tests yet. It is next on my to-do list, for real! But some help with doing that would be great.
I'd also be happy to take over this repo if you'd prefer. I have some good experience developing for WordPress and Ruby stuff!
NINJA EDIT - Version bumped to 1.0, added testing for the entire Gem, major cleanup. Would like you to post a link to my repo if you won't merge my request.