Add TokenProvider::email() method #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valkum
reviewed
Jul 15, 2024
| @@ -51,6 +51,10 @@ impl TokenProvider for GCloudAuthorizedUser { | |||
| Ok(token) | |||
| } | |||
|
|
|||
| async fn email(&self) -> Result<String, Error> { | |||
| run(&["auth", "print-identity-token"]) | |||
There was a problem hiding this comment.
I guess this needs additional steps as it only returns the token but not the email.
|
Wondering if any users make use of the trait. If not, it does make sense to exchange this with an enum. The types of auth are finite, and I currently can't see any need to be able to specify your own token provider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
TokenProvideris a trait (and not sealed), this is technically a breaking change. Since there's just been a breaking change a month ago, not sure if we want a breaking change for this again? If so, maybe also turn it into an enum instead of a trait...r? @valkum